Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Whitespace issues for related, cross and upsell grids #21582

Merged
merged 1 commit into from
Mar 16, 2019
Merged

Fixed Whitespace issues for related, cross and upsell grids #21582

merged 1 commit into from
Mar 16, 2019

Conversation

amol2jcommerce
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Whitespace issues for related, cross and upsell grids #21541: Whitespace issues for related, cross and upsell grids
  2. Magento 2.3

Manual testing scenarios (*)

  1. Go into a product and add more related, cross sell and upsell products so the grid will wrap
  2. Clear cache, go on frontend and check
  3. Add product to cart, go view cart and check

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 5, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@VladimirZaets
Copy link
Contributor

Hi @amol2jcommerce, please, sign CLA, otherwise, we can't process your pull request

@VladimirZaets VladimirZaets self-assigned this Mar 5, 2019
@amol2jcommerce amol2jcommerce force-pushed the Whitespace-issues-for-related-cross-and-upsell-grids branch from 2844bcc to 9ab463f Compare March 6, 2019 05:48
@amol2jcommerce
Copy link
Contributor Author

amol2jcommerce commented Mar 6, 2019 •
edited
Loading

Hi @VladimirZaets I sign CLA. can you please review.

@ghost
Copy link

ghost commented Mar 6, 2019

@amol2jcommerce unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4451 has been created to process this Pull Request

@soleksii soleksii self-assigned this Mar 13, 2019
@soleksii
Copy link

✔️ QA Passed

@nmalevanec nmalevanec self-assigned this Mar 13, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 16, 2019
Closed
@ghost
Copy link

ghost commented Mar 16, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit 9ab463f into magento:2.3-develop Mar 16, 2019
magento-engcom-team pushed a commit that referenced this pull request Mar 16, 2019
@sidolov
ENGCOM-4451: Fixed Whitespace issues for related, cross and upsell gr…
3623804 
…ids #21582
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 16, 2019
@shrinet shrinet mentioned this pull request Apr 3, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

@nmalevanec nmalevanec

@soleksii soleksii

Labels
Area: Design/Frontend Cleanup Partner: Two Jay partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@amol2jcommerce @magento-engcom-team @magento-cicd2 @VladimirZaets @soleksii @nmalevanec